JFTR, v2 in gerrit is "the same as v1, just rebased", so taking what is
already on the list here.

And indeed, in the only call chain to this, we have

    string_mod_remap_name(up->username);

.. so this should better be non-NULL :-)  (ASSERT(str) in string_mod()).

Your patch has been applied to the master branch.

commit d9af13e8c222cba41000202908663a6d1e2cd028
Author: Arne Schwabe
Date:   Tue Jan 21 17:12:47 2025 +0100

     Remove comparing username to NULL in tls_lock_username

     Signed-off-by: Arne Schwabe <[email protected]>
     Acked-by: Frank Lichtenheld <[email protected]>
     Message-Id: <[email protected]>
     URL: 
https://www.mail-archive.com/[email protected]/msg30520.html
     Signed-off-by: Gert Doering <[email protected]>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to