Attention is currently required from: cron2, flichtenheld, its_Giaan, plaisthos.

ordex has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/880?usp=email )

Change subject: mroute/management: fix unitialized variable (UNINIT)
......................................................................


Patch Set 1:

(1 comment)

File src/openvpn/manage.c:

http://gerrit.openvpn.net/c/openvpn/+/880/comment/387f5a9f_83884c97 :
PS1, Line 573:                             port, p3);
> not sure we should use `p3` here (what if a user sends 'foo'?). […]
passing 'foo' will lead to ascii2proto() returning -1, which in turn will lead 
to "no client found", so we won't hit this print



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/880?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4be0ff4d308213d2ef8ba66bd3178eee1f60fff1
Gerrit-Change-Number: 880
Gerrit-PatchSet: 1
Gerrit-Owner: its_Giaan <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: ordex <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: cron2 <[email protected]>
Gerrit-Attention: its_Giaan <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Tue, 28 Jan 2025 14:22:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <[email protected]>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to