This is somewhat of a cleanup-repair-broken-API patch, and it took us
a few rounds to get this in a nice shape. commit dda93f304 adds a
"proto" field to the mroute hashing & comparison to disambiguate
udp and tcp connects, and that promptly broke the "kill $ip:$port"
management command (not matching at all, and Coverity complaining
about "proto" being uninitialized there). Change that API command
to do "kill $proto:$ip:$port" now, and adjust the documentation(!).
NOTE: this is still broken for IPv6, as only IPv4 addresses are parsed -
and this has been broken since IPv6 transport has been introduced - so
I guess nobody is really using it...
Your patch has been applied to the master branch.
commit 10a82b1f2fe3cf295a4a44dac1f61fdf750c172a
Author: Gianmarco De Gregori
Date: Wed Jan 29 17:16:08 2025 +0100
mroute/management: repair mgmt client-kill for mroute with proto
Signed-off-by: Gianmarco De Gregori <[email protected]>
Acked-by: Gert Doering <[email protected]>
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg30716.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
