Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/868?usp=email )
Change subject: Extend the unit test for data channel packets with aead limit tests ...................................................................... Patch Set 2: (4 comments) Patchset: PS2: Looks good! File tests/unit_tests/openvpn/test_ssl.c: http://gerrit.openvpn.net/c/openvpn/+/868/comment/aaf1046f_c7682d5e : PS2, Line 369: Nitpick: Did you mean to put 2 blank lines here? http://gerrit.openvpn.net/c/openvpn/+/868/comment/90415ab6_73c373e1 : PS2, Line 403: \ Why a line continuation? http://gerrit.openvpn.net/c/openvpn/+/868/comment/a772ba34_52699165 : PS2, Line 432: /* Ensure that we are still on the initial key (unit test uses 4) : * or that it is 0 when epoch is not in use */ : assert_int_equal(co->key_ctx_bi.encrypt.epoch, expected_epoch); I was confused where the 4 comes from. I guess the previous test sets it that way? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/868?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I15c7cfdddb06d4530d669b222a3c65db5169b29a Gerrit-Change-Number: 868 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: MaxF <m...@max-fillinger.net> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Wed, 29 Jan 2025 18:22:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
