Attention is currently required from: cron2, flichtenheld, plaisthos.

stipa has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/879?usp=email )

Change subject: route.c: improve get_default_gateway() logic on Windows
......................................................................


Patch Set 3:

(2 comments)

File src/openvpn/route.c:

http://gerrit.openvpn.net/c/openvpn/+/879/comment/a0e6aa22_44e519ff :
PS2, Line 2812:     DWORD a_index = adapter_index_of_ip(adapters, 
rgi->gateway.addr, NULL, &rgi->gateway.netmask);
> This fails for `ON_LINK` targets, where `gateway.addr == 0.0.0.0`. […]
Done


http://gerrit.openvpn.net/c/openvpn/+/879/comment/b7f7fe7b_1e60f462 :
PS2, Line 2827:
> the IPv6 part sets the `RGI_ON_LINK` flag when the `BestRoute. […]
Done



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/879?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6c7e1cef637fe9fb3f3bc6ff4fb2c65599cd86fb
Gerrit-Change-Number: 879
Gerrit-PatchSet: 3
Gerrit-Owner: stipa <lstipa...@gmail.com>
Gerrit-Reviewer: cron2 <g...@greenie.muc.de>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: cron2 <g...@greenie.muc.de>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Comment-Date: Fri, 31 Jan 2025 13:32:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <g...@greenie.muc.de>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to