Attention is currently required from: flichtenheld, its_Giaan, ordex, plaisthos.

cron2 has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/761?usp=email )

Change subject: if a local IPv6 address is provided, socket must be v6-only
......................................................................


Patch Set 16: Code-Review-1

(1 comment)

Commit Message:

http://gerrit.openvpn.net/c/openvpn/+/761/comment/78420fab_8b8d4fb4 :
PS1, Line 7: if
> The only thing that comes to my mind is that if we wanted to have a wildcard 
> ipv6 socket (i.e. […]
The more I think about this, the more I find that we should cover this by 
documentation :-) - changing the default bind behaviour will break people's 
config on upgrading a server config with `local ::` or `proto udp6`, because it 
will stop listening to IPv4.

So what we should do is to document that `* udp6` or `::`will default to `ipv4 
+ ipv6`, unless `bind ipv6only` is configured - and not try to solve this in 
code, at least not for 2.7 when "just one socket" configs will be the normal 
case on upgrading.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/761?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I705fd9bf9298a54560eca12e3797351f4af321a7
Gerrit-Change-Number: 761
Gerrit-PatchSet: 16
Gerrit-Owner: its_Giaan <gianma...@mandelbit.com>
Gerrit-Reviewer: cron2 <g...@greenie.muc.de>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-CC: ordex <a...@unstable.cc>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: its_Giaan <gianma...@mandelbit.com>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Attention: ordex <a...@unstable.cc>
Gerrit-Comment-Date: Sun, 02 Feb 2025 21:12:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com>
Comment-In-Reply-To: ordex <a...@unstable.cc>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to