cron2 has uploaded a new patch set (#3) to the change originally created by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/885?usp=email )
The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: dco-win: disable dco in server mode if multiple --local options defined ...................................................................... dco-win: disable dco in server mode if multiple --local options defined dco-win doesn't yet support multisocket, so for the time being we have to fallback to tap-windows6. Change-Id: I8724eda269b816dd2cfd0833d467e6d24054e96f Signed-off-by: Lev Stipakov <l...@openvpn.net> Acked-by: Gert Doering <g...@greenie.muc.de> Message-Id: <20250205122341.4944-1-g...@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30805.html Signed-off-by: Gert Doering <g...@greenie.muc.de> --- M src/openvpn/dco.c 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/85/885/3 diff --git a/src/openvpn/dco.c b/src/openvpn/dco.c index b5a2136..c65aece 100644 --- a/src/openvpn/dco.c +++ b/src/openvpn/dco.c @@ -279,6 +279,12 @@ msg(msglevel, "NOTE: --remote is not defined. This DCO version doesn't support multipeer. Disabling Data Channel Offload"); return false; } + + if ((mode == MODE_SERVER) && (ce->local_list->len > 1)) + { + msg(msglevel, "NOTE: multiple --local options defined, disabling data channel offload"); + return false; + } #endif return true; @@ -355,6 +361,12 @@ return false; } + if ((o->mode == MODE_SERVER) && o->ce.local_list->len > 1) + { + msg(msglevel, "multiple --local options defined, disabling data channel offload"); + return false; + } + #elif defined(TARGET_LINUX) /* if the device name is fixed, we need to check if an interface with this * name already exists. IF it does, it must be a DCO interface, otherwise -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/885?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I8724eda269b816dd2cfd0833d467e6d24054e96f Gerrit-Change-Number: 885 Gerrit-PatchSet: 3 Gerrit-Owner: stipa <lstipa...@gmail.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-MessageType: newpatchset
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
