Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/890?usp=email
to review the following change.
Change subject: Always use a 0.0.0.0/0 default on Android instead of def1
......................................................................
Always use a 0.0.0.0/0 default on Android instead of def1
Certain handset manufactures (like Samsung iirc) are handling
0.0.0.0/0 different from the split /1 routes, so push the 0.0.0.0/0
route to the OS.
Change-Id: I22e4b73e744c765a43bdb29f6e18813d103ea757
Signed-off-by: Arne Schwabe <[email protected]>
---
M src/openvpn/route.c
1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/90/890/1
diff --git a/src/openvpn/route.c b/src/openvpn/route.c
index d895e1c..71a0bbc9 100644
--- a/src/openvpn/route.c
+++ b/src/openvpn/route.c
@@ -1078,6 +1078,17 @@
if (rl->flags & RG_REROUTE_GW)
{
+#ifdef TARGET_ANDROID
+ add_route3(0,
+ 0,
+ rl->spec.remote_endpoint,
+ tt,
+ flags,
+ &rl->rgi,
+ es,
+ ctx);
+
+#else /* ifdef TARGET_ANDROID */
if (rl->flags & RG_DEF1)
{
/* add new default route (1st component) */
@@ -1102,6 +1113,7 @@
ret = add_route3(0, 0, rl->spec.remote_endpoint, tt,
flags, &rl->rgi, es, ctx) && ret;
}
+#endif /* ifdef TARGET_ANDROID */
}
/* set a flag so we can undo later */
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/890?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I22e4b73e744c765a43bdb29f6e18813d103ea757
Gerrit-Change-Number: 890
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
