Attention is currently required from: cron2, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/816?usp=email )
Change subject: dco-win: kernel notifications ...................................................................... Patch Set 20: (3 comments) File src/openvpn/dco_win.c: http://gerrit.openvpn.net/c/openvpn/+/816/comment/cf098fa0_497af99a : PS20, Line 644: dco_handle_overlapped_success(dco_context_t *dco, bool queued) > can you add a comment what this function does? As a non-windows programmer I > find `Overlapped` a fo […] Will do. File src/openvpn/mudp.c: http://gerrit.openvpn.net/c/openvpn/+/816/comment/835acd5c_18103b81 : PS20, Line 409: #if defined(ENABLE_DCO) && (defined(TARGET_LINUX) || defined(TARGET_FREEBSD) || defined(TARGET_WIN32)) > this is a minor nitpick, but I find this line very long and hard to read now > - can you wrap it? […] Done File src/openvpn/multi.c: http://gerrit.openvpn.net/c/openvpn/+/816/comment/899c1243_9d323748 : PS20, Line 3231: #if defined(ENABLE_DCO) && (defined(TARGET_LINUX) || defined(TARGET_FREEBSD) || defined(TARGET_WIN32)) > same thing Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/816?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iedc10616225f6769c66d3c29d4a462b622ebbc6e Gerrit-Change-Number: 816 Gerrit-PatchSet: 20 Gerrit-Owner: stipa <lstipa...@gmail.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: cron2 <g...@greenie.muc.de> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Thu, 20 Feb 2025 08:06:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <g...@greenie.muc.de> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
