Attention is currently required from: d12fk, flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/825?usp=email )
Change subject: dns: do not use netsh to set name server addresses ...................................................................... Patch Set 13: (1 comment) File src/openvpnserv/interactive.c: http://gerrit.openvpn.net/c/openvpn/+/825/comment/34e70988_8404e3c3 : PS13, Line 1929: } I am a bit worried about this static buffer and no overflow check - if we ever increase the dns_cfg_message_t to `addr[8]`, will we remember to also increase the `CHAR addrs[256]` here? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/825?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Id2bed0908e84c19b8fb6fe806376316793e550b4 Gerrit-Change-Number: 825 Gerrit-PatchSet: 13 Gerrit-Owner: d12fk <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-Reviewer: stipa <[email protected]> Gerrit-CC: cron2 <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Attention: d12fk <[email protected]> Gerrit-Comment-Date: Wed, 12 Mar 2025 10:54:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
