Attention is currently required from: plaisthos, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/854?usp=email )
Change subject: Post tchar.h removal cleanup ...................................................................... Patch Set 3: (1 comment) File src/tapctl/basic.h: http://gerrit.openvpn.net/c/openvpn/+/854/comment/d1853ec4_d79d4a31 : PS2, Line 25: /* We do not support non-unicode builds */ > Shouldn't we instead just define UNICODE in project file or ensure there it > has defined? And have an […] I don't see the advantage. This here is the most central place. Otherwise you always have to make it consistent over all build systems? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/854?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ib3a166ead912beb2a591105c84d96d342664c05f Gerrit-Change-Number: 854 Gerrit-PatchSet: 3 Gerrit-Owner: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: stipa <lstipa...@gmail.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: stipa <lstipa...@gmail.com> Gerrit-Comment-Date: Tue, 18 Mar 2025 12:19:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: stipa <lstipa...@gmail.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
