Attention is currently required from: flichtenheld, plaisthos.

Hello plaisthos, flichtenheld,

I'd like you to do a code review.
Please visit

    http://gerrit.openvpn.net/c/openvpn/+/919?usp=email

to review the following change.


Change subject: t_server_null: add multi-socket testing
......................................................................

t_server_null: add multi-socket testing

This makes the first server instance listen on both 127.0.0.1 and ::1
and adds a client that connects to the latter.

Change-Id: I4ebe1158c36a641888131e824f59004a0f8fb4c5
Signed-off-by: Samuli Seppänen <samuli.seppa...@gmail.com>
---
M tests/t_server_null_default.rc
1 file changed, 11 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/19/919/1

diff --git a/tests/t_server_null_default.rc b/tests/t_server_null_default.rc
index e7bf5bc..0775192 100755
--- a/tests/t_server_null_default.rc
+++ b/tests/t_server_null_default.rc
@@ -48,7 +48,7 @@
 SERVER_SERVER_1="--server 10.29.41.0 255.255.255.0"
 SERVER_MGMT_PORT_1="11194"
 SERVER_EXEC_1="${SERVER_EXEC}"
-SERVER_CONF_1="${SERVER_CONF_BASE} ${SERVER_SERVER_1} --lport 1194 --proto udp 
--management 127.0.0.1 ${SERVER_MGMT_PORT_1}"
+SERVER_CONF_1="${SERVER_CONF_BASE} ${SERVER_SERVER_1} --local ::1 --lport 1194 
--proto udp --management 127.0.0.1 ${SERVER_MGMT_PORT_1}"

 SERVER_NAME_2="t_server_null_server-1195_tcp"
 SERVER_SERVER_2="--server 10.29.42.0 255.255.255.0"
@@ -65,14 +65,19 @@
 CLIENT_CIPHER_OPTS=""
 CLIENT_CERT_OPTS="--ca ${CA} --cert ${CLIENT_CERT} --key ${CLIENT_KEY} 
--tls-auth ${TA} 1"

-TEST_RUN_LIST="1 1L 2 2L 3"
+TEST_RUN_LIST="1a 1b 1L 2 2L 3"
 CLIENT_CONF_BASE="${CLIENT_NULL_OPTS} ${CLIENT_BASE_OPTS} 
${CLIENT_CIPHER_OPTS} ${CLIENT_CERT_OPTS}"
 CLIENT_CONF_BASE_LWIP="${CLIENT_LWIP_OPTS} ${CLIENT_BASE_OPTS} 
${CLIENT_CIPHER_OPTS} ${CLIENT_CERT_OPTS}"

-TEST_NAME_1="t_server_null_client.sh-openvpn_current_udp"
-SHOULD_PASS_1="yes"
-CLIENT_EXEC_1="${CLIENT_EXEC}"
-CLIENT_CONF_1="${CLIENT_CONF_BASE} --remote 127.0.0.1 1194 udp --proto udp"
+TEST_NAME_1a="t_server_null_client.sh-openvpn_current_udp_ipv4_remote"
+SHOULD_PASS_1a="yes"
+CLIENT_EXEC_1a="${CLIENT_EXEC}"
+CLIENT_CONF_1a="${CLIENT_CONF_BASE} --remote 127.0.0.1 1194 udp --proto udp"
+
+TEST_NAME_1b="t_server_null_client.sh-openvpn_current_udp_ipv6_remote"
+SHOULD_PASS_1b="yes"
+CLIENT_EXEC_1b="${CLIENT_EXEC}"
+CLIENT_CONF_1b="${CLIENT_CONF_BASE} --remote ::1 1194 udp --proto udp"

 TEST_NAME_1L="t_server_null_client.sh-openvpn_current_udp_lwip"
 SHOULD_PASS_1L="yes"

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/919?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4ebe1158c36a641888131e824f59004a0f8fb4c5
Gerrit-Change-Number: 919
Gerrit-PatchSet: 1
Gerrit-Owner: mattock <sas...@proton.me>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-MessageType: newchange
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to