Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/829?usp=email
to review the following change.
Change subject: Disable clang-format for some code parts
......................................................................
Disable clang-format for some code parts
These do not come out better with clang-format,
so leave them be.
Change-Id: I4dd0c44982955f16ec4a3f167d4e6f3e9b4dbc11
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M src/openvpn/ssl_common.h
M src/tapctl/main.c
2 files changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/29/829/3
diff --git a/src/openvpn/ssl_common.h b/src/openvpn/ssl_common.h
index 4e54001..97c5041 100644
--- a/src/openvpn/ssl_common.h
+++ b/src/openvpn/ssl_common.h
@@ -75,6 +75,7 @@
*
* @{
*/
+/* clang-format off */
#define S_ERROR (-2) /**< Error state. */
#define S_ERROR_PRE (-1) /**< Error state but try to send out alerts
* before killing the keystore and moving
@@ -102,7 +103,7 @@
#define S_GENERATED_KEYS 7 /**< The data channel keys have been generated
* The TLS session is fully authenticated
* when reaching this state. */
-
+/* clang-format on */
/* Note that earlier versions also had a S_OP_NORMAL state that was
* virtually identical with S_ACTIVE and the code still assumes everything
* >= S_ACTIVE to be fully operational */
diff --git a/src/tapctl/main.c b/src/tapctl/main.c
index 551a8e6..d27da6b 100644
--- a/src/tapctl/main.c
+++ b/src/tapctl/main.c
@@ -37,6 +37,7 @@
#endif
+/* clang-format off */
const WCHAR title_string[] =
_L(PACKAGE_NAME) L" " _L(PACKAGE_VERSION)
;
@@ -111,6 +112,7 @@
L"\n"
L"tapctl delete <adapter GUID | adapter name>\n"
;
+/* clang-format on */
/**
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/829?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4dd0c44982955f16ec4a3f167d4e6f3e9b4dbc11
Gerrit-Change-Number: 829
Gerrit-PatchSet: 3
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel