Attention is currently required from: flichtenheld, its_Giaan, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/925?usp=email )
Change subject: Fix FreeBSD-DCO and Multisocket interaction ...................................................................... Patch Set 1: (3 comments) Patchset: PS1: questions... File src/openvpn/dco.c: http://gerrit.openvpn.net/c/openvpn/+/925/comment/9d655d2e_4fc29dc7 : PS1, Line 263: if (ce->local_list) will this also catch clients that have no `--local` at all, just `--remote ... tcp`? FreeBSD DCO also needs to be disabled for TCP clients. http://gerrit.openvpn.net/c/openvpn/+/925/comment/95331584_9525203f : PS1, Line 277: if (!proto_is_udp(ce->proto) && mode == MODE_SERVER) this looks as if we need the fix for windows too... maybe keep & use the has_tcp_in_local_list() for this? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/925?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I9b6359076a61ae2bbb8e5cea00e33969cb5f92cf Gerrit-Change-Number: 925 Gerrit-PatchSet: 1 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: cron2 <g...@greenie.muc.de> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: its_Giaan <gianma...@mandelbit.com> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Fri, 28 Mar 2025 21:34:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
