Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/929?usp=email
to review the following change.
Change subject: GHA: Pin version of CMake for all builds
......................................................................
GHA: Pin version of CMake for all builds
Turns out that "apt install cmake" is useless since
Github installs also CMake but not as a package. So
make sure we control which CMake we get and not
Github.
Switch to get-cmake action (which also installs ninja)
and remove the installation via apt.
Change-Id: Ief11d5d7ccae084c863b50054d4e97c71f57d6f0
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M .github/workflows/build.yaml
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/29/929/1
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index b1af7ec..617b866 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -54,6 +54,7 @@
steps:
- name: Checkout OpenVPN
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 #
v4.2.2
+ - uses: lukka/get-cmake@56d043d188c3612951d8755da8f4b709ec951ad6 #
v3.31.6
- name: Install vcpkg
uses: lukka/run-vcpkg@5e0cab206a5ea620130caf672fce3e4a6b5666a1 # v11.5
with:
@@ -78,10 +79,11 @@
VCPKG_ROOT: ${{ github.workspace }}/vcpkg
steps:
- name: Install dependencies
- run: sudo apt update && sudo apt install -y mingw-w64 unzip cmake
ninja-build build-essential wget python3-docutils man2html-base
+ run: sudo apt update && sudo apt install -y mingw-w64 unzip
build-essential wget python3-docutils man2html-base
- name: Checkout OpenVPN
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 #
v4.2.2
+ - uses: lukka/get-cmake@56d043d188c3612951d8755da8f4b709ec951ad6 #
v3.31.6
- name: Restore from cache and install vcpkg
uses: lukka/run-vcpkg@5e0cab206a5ea620130caf672fce3e4a6b5666a1 # v11.5
with:
@@ -457,13 +459,14 @@
steps:
- name: Install dependencies
- run: sudo apt update && sudo apt install -y cmake gcc ninja-build
golang make liblzo2-dev libpam0g-dev liblz4-dev linux-libc-dev man2html clang
libcmocka-dev python3-docutils python3-jinja2 python3-jsonschema libtool
automake autoconf pkg-config libcap-ng-dev libnl-genl-3-dev
+ run: sudo apt update && sudo apt install -y gcc golang make
liblzo2-dev libpam0g-dev liblz4-dev linux-libc-dev man2html clang libcmocka-dev
python3-docutils python3-jinja2 python3-jsonschema libtool automake autoconf
pkg-config libcap-ng-dev libnl-genl-3-dev
- name: "AWS-LC: checkout"
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 #
v4.2.2
with:
path: aws-lc
repository: aws/aws-lc
ref: v1.42.0
+ - uses: lukka/get-cmake@56d043d188c3612951d8755da8f4b709ec951ad6 #
v3.31.6
- name: "AWS-LC: build"
run: |
mkdir build
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/929?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ief11d5d7ccae084c863b50054d4e97c71f57d6f0
Gerrit-Change-Number: 929
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
