Thanks for fixing this.  Stared at the code, discussed a bit, and actually
went out and tested (on FreeBSD 14 server test set).  Without the patch
an instance with both UDP and TCP starts with DCO and dies miserably
when a TCP connection comes in - with the patch, it will disable DCO,
and do UDP+TCP in userland (kernel doesn't do TCP, so there is nothing
we can do).  With multiple UDP sockets, DCO works.

Your patch has been applied to the master branch.

commit a061b3a94c5489a2f207189343f1c235e8181b87
Author: Gianmarco De Gregori
Date:   Wed Apr 2 15:21:42 2025 +0200

     Fix FreeBSD-DCO and Multisocket interaction

     Signed-off-by: Gianmarco De Gregori <gianma...@mandelbit.com>
     Acked-by: Gert Doering <g...@greenie.muc.de>
     Message-Id: <20250402132148.18810-1-g...@greenie.muc.de>
     URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg31324.html
     Signed-off-by: Gert Doering <g...@greenie.muc.de>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to