Attention is currently required from: flichtenheld. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/918?usp=email )
Change subject: Fix compatibility with mbedTLS 2.28.10+ and 3.6.3+ ...................................................................... Patch Set 1: (1 comment) File src/openvpn/ssl_mbedtls.c: http://gerrit.openvpn.net/c/openvpn/+/918/comment/5a92e1f5_b6450745 : PS1, Line 1250: mbedtls_ssl_set_hostname(ks_ssl->ctx, NULL); Should we check the return value? The only possible errors are "allocation failed" and "hostname too long", both of which don't apply. But ignoring a return value feels a bit wrong to me. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/918?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I8bbb6ffdac7d0029dbf3c13e62c11b61813c15ef Gerrit-Change-Number: 918 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: MaxF <m...@max-fillinger.net> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Wed, 26 Mar 2025 15:05:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
