If everything works fine, nobody needs to look at this - but if things break, extra information is always good to have. I have stared at the code, and compared code & compat code with the OpenSSL documentation, and this all makes sense. The buildbots have tested it (t_client tests actually excercising this code, with various OpenSSL and mbedTLS versions) and nothing breaks.
Your patch has been applied to the master branch. Commit message adjusted ("not" inserted") as discussed. commit 5b7a1bc34c8a3f86dfcc91b7a1aa520b1c549390 Author: Arne Schwabe Date: Wed Apr 9 14:24:03 2025 +0200 Also print key agreement when printing negotiated details Signed-off-by: Arne Schwabe <a...@rfc2549.org> Acked-by: Gert Doering <g...@greenie.muc.de> Message-Id: <20250409122409.17616-1-g...@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg31393.html Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel