I'm not claiming to be an expert on Windows code and NRPT especially,
but I've stared hard at the code and this all seems to make sense
(including and especially memory and string handling). Lev tested
this in detail, I just compile tested.
(The code change to openvpn itself is fairly straightforward and not
that windows specific. The code change to the iservice is a tough one :-) ).
As discussed on IRC, sorry for the "%s" messup - but I would really
appreciate having "code fixes" and "new code" in separate commits, as
that makes reviewing & shipping the "fixes" quicker, and reviewing the
"new code" easier (less lines...).
Your patch has been applied to the master branch.
commit 0f3b7d17d565a422bfddc0f393b7712031e5bdbb
Author: Heiko Hund
Date: Mon Apr 14 20:06:26 2025 +0200
win: implement --dns option support with NRPT
Signed-off-by: Heiko Hund <he...@ist.eigentlich.net>
Acked-by: Lev Stipakov <lstipa...@gmail.com>
Message-Id: <20250414180636.31936-1-g...@greenie.muc.de>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg31426.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
