Attention is currently required from: flichtenheld, its_Giaan, plaisthos.

ordex has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/941?usp=email )

Change subject: Add support to "ovpn" aka "in upstream kernel"
......................................................................


Patch Set 1: -Code-Review

(2 comments)

Patchset:

PS1:
> I also got the following: […]
Gianmarco confirmed that openvpn cleans the interface up correctly.
We need to check with the NM guy why this is happening under NM.
Therefore this is not an issue with this patch.


PS1:
> [re-adding comment as it was set a Resolved by accident] […]
this is something that we could deal with in a separate patch.
Basically in-kernel modules do not have a separate "version" file.
We will have it when compiling the 'ovpn' through dkms, but we won't when using 
the in-kernel version.

Therefore we will have to extend the check and possibly print the kernel 
version when using the in-kernel one.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/941?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I009f4e7ad38636f1c0b78d267561194c2bb4c051
Gerrit-Change-Number: 941
Gerrit-PatchSet: 1
Gerrit-Owner: its_Giaan <gianma...@mandelbit.com>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: ordex <anto...@mandelbit.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: its_Giaan <gianma...@mandelbit.com>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Comment-Date: Thu, 17 Apr 2025 11:22:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: ordex <anto...@mandelbit.com>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to