Attention is currently required from: flichtenheld, plaisthos, stipa. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/942?usp=email )
Change subject: ssl_openssl.c: Prevent potential double-free ...................................................................... Patch Set 1: Code-Review-1 (2 comments) File src/openvpn/ssl_openssl.c: http://gerrit.openvpn.net/c/openvpn/+/942/comment/44b20348_cad4db27 : PS1, Line 1158: while (!OSSL_STORE_eof(store_ctx)) > Yes, this is what happened with mattock's certs. Done http://gerrit.openvpn.net/c/openvpn/+/942/comment/94540f39_f171d755 : PS1, Line 1189: if (info) there is no need for this check. Like most free() methods, passing NULL leads to nothing. >From the manpage: OSSL_STORE_INFO_free() frees a OSSL_STORE_INFO and its contained type. If the argument is NULL, nothing is done. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/942?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I4507be07cd5573b2117e837ef03187535a38a4b1 Gerrit-Change-Number: 942 Gerrit-PatchSet: 1 Gerrit-Owner: stipa <lstipa...@gmail.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: ordex <anto...@mandelbit.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: stipa <lstipa...@gmail.com> Gerrit-Comment-Date: Thu, 17 Apr 2025 11:39:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: ordex <anto...@mandelbit.com> Comment-In-Reply-To: stipa <lstipa...@gmail.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel