Attention is currently required from: plaisthos.

flichtenheld has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/945?usp=email )

Change subject: Make dh none behaviour default if not specific and add dh auto
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

Commit Message:

http://gerrit.openvpn.net/c/openvpn/+/945/comment/e1153c4e_50db37a0 :
PS1, Line 7: Make dh none behaviour default if not specific and add dh auto
Do you mean "specified" instead of "specific"?


File doc/man-sections/tls-options.rst:

http://gerrit.openvpn.net/c/openvpn/+/945/comment/b9aff705_92f37f5f :
PS1, Line 183:   Set ``file`` to :code:`auto` enables using builtin Diffie 
Hellman
"Setting"


http://gerrit.openvpn.net/c/openvpn/+/945/comment/7b830145_762c2aad :
PS1, Line 188:   use the public well-known parameter or using ``none``.
"parameters"


File src/openvpn/options.c:

http://gerrit.openvpn.net/c/openvpn/+/945/comment/c4fa3ce2_91eeefc1 :
PS1, Line 3716:             o->dh_file = "auto";
It is already "auto", so this seems redundant.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/945?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ica02244c9f0ac9b4690a51f940fda9d900465289
Gerrit-Change-Number: 945
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <arne-open...@rfc2549.org>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Comment-Date: Wed, 23 Apr 2025 11:06:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to