Attention is currently required from: flichtenheld, plaisthos, selvanair. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/943?usp=email )
Change subject: win: create adapter on demand ...................................................................... Patch Set 2: (3 comments) File src/openvpn/tun.c: http://gerrit.openvpn.net/c/openvpn/+/943/comment/e2801d99_1753f1ba : PS2, Line 3781: static struct device_instance_id_interface * > This change is not required nor advisable. Same with panel_reg and tap_reg > below. […] Acknowledged http://gerrit.openvpn.net/c/openvpn/+/943/comment/78901121_07cb7bb3 : PS2, Line 6656: struct device_instance_id_interface *device_instance_id_interface = get_device_instance_id_interface(gc); > Define these three as "const struct ...". One can still re-assign them as > required below. right, the data is const, but not the pointer. http://gerrit.openvpn.net/c/openvpn/+/943/comment/36c92149_f13d12e9 : PS2, Line 6731: if (tun_try_open_device(tt, *device_guid, device_instance_id_interface)) > I think we should not limit this using the adapter_created flag here. […] Acknowledged -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/943?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I621d44ec6b0facc524875c15ddfd11ec47b06c15 Gerrit-Change-Number: 943 Gerrit-PatchSet: 2 Gerrit-Owner: stipa <lstipa...@gmail.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: selvanair <selva.n...@gmail.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: selvanair <selva.n...@gmail.com> Gerrit-Comment-Date: Thu, 24 Apr 2025 06:58:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: selvanair <selva.n...@gmail.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
