Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/945?usp=email )
Change subject: Make dh none behaviour default if not specified and add dh auto ...................................................................... Patch Set 2: Code-Review-1 (6 comments) Patchset: PS2: Some more nitpicking File doc/man-sections/tls-options.rst: http://gerrit.openvpn.net/c/openvpn/+/945/comment/0875d49b_2e79eee5 : PS1, Line 183: Set ``file`` to :code:`auto` enables using builtin Diffie Hellman > "Setting" Done http://gerrit.openvpn.net/c/openvpn/+/945/comment/24f9ab7c_0d7f8e5e : PS1, Line 188: use the public well-known parameter or using ``none``. > "parameters" Done File doc/man-sections/tls-options.rst: http://gerrit.openvpn.net/c/openvpn/+/945/comment/46dda9bc_dd7a8286 : PS2, Line 179: Note that this requires peers to be using an SSL library that supports "to use" instead of "to be using". While not incorrect I think it sounds clunky. http://gerrit.openvpn.net/c/openvpn/+/945/comment/ff6311bb_0efb9609 : PS2, Line 188: use the public well-known parameters or using ``none``. "use" versus "using". Maybe just remove the "using"? File src/openvpn/ssl.c: http://gerrit.openvpn.net/c/openvpn/+/945/comment/3cee585a_d672dc5f : PS2, Line 538: if (options->dh_file && !strcmp(options->dh_file, "auto")) Any reason not to use streq() here like in options.c? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/945?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ica02244c9f0ac9b4690a51f940fda9d900465289 Gerrit-Change-Number: 945 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Comment-Date: Fri, 25 Apr 2025 11:39:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
