Looks generally reasonable. Lev has tested this thoroughly and confirms it works :-) - there is a bug in string length calculation in here (wide/normal string) so the code as it stands does not work correctly for multiple domains. To be fixed in the next patch (#1028).
I have only compile tested this (ubuntu+mingw). Your patch has been applied to the master branch. commit dcc2385c033ac5df98968aad6899ddc8c4d2240e Author: Heiko Hund Date: Tue May 20 12:51:12 2025 +0200 win: match search domains when creating exclude rules Signed-off-by: Heiko Hund <he...@ist.eigentlich.net> Acked-by: Lev Stipakov <lstipa...@gmail.com> Message-Id: <20250520105119.10431-1-g...@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg31731.html Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel