Looks reasonable, and Arne & Heiko confirm that it works. So I've not done any testing, just skimmed over the change to see what it touches.
Your patch has been applied to the master branch. commit 022cd3e7fe19e013709ecd3104aaf93b6e6abe89 Author: Heiko Hund Date: Fri Jul 11 12:08:53 2025 +0200 move macOS dns-updown common code into functions Signed-off-by: Heiko Hund <he...@ist.eigentlich.net> Acked-by: Frank Lichtenheld <fr...@lichtenheld.com> Message-Id: <20250711100853.242102-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32105.html Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel