Attention is currently required from: flichtenheld, plaisthos, ralf_lici. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1091?usp=email )
Change subject: improve float collision logging ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: works! Disabled the "goto done" part from the "same peer-id" check, and played with the LAN cable :-) - resulting in ``` 2025-07-18 21:14:25 us=793140 cron2-freebsd-tc-amd64/udp6:193.149.48.173:49409 peer-id=0 disallowing peer 0 (cron2-freebsd-tc-amd64) from floating to its own address (udp6:193.149.48.173:49409) 2025-07-18 21:14:25 us=793175 cron2-freebsd-tc-amd64/udp6:193.149.48.173:49409 peer-id=0 closing instance cron2-freebsd-tc-amd64/udp6:193.149.48.173:49409 peer-id=0 due to float collision with cron2-freebsd-tc-amd64/udp6:193.149.48.173:49409 peer-id=0 using the same certificate ``` (and then, of course, it SIGSEGVs, but that's expected - so the extra logging makes this a much clearer picture. Could not reproduce with two different clients, but I don't think this will add extra testing coverage) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1091?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I217cfb319b85fd75a88f7d4d50c374d28771df28 Gerrit-Change-Number: 1091 Gerrit-PatchSet: 1 Gerrit-Owner: ralf_lici <r...@mandelbit.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: ralf_lici <r...@mandelbit.com> Gerrit-Comment-Date: Fri, 18 Jul 2025 19:16:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
