So, this has been quite a journey... (and thanks, Marco, for keeping your
patience). Lev has tested and +2'ed v11, which was then lost in the
"rebase / avoid conflict" for v12. Up to v20, only reviews, and then I
asked for lots of stylistic / code organizational changes which then
brought this up to v22...
I have stared a lot at the code, and I have run the full "normal client
and server side test" bed on it. I have not actually tested incoming
PUSH_UPDATE messages, so at this point I have good faith that this does
what it is supposed to do - and I'm pretty sure that it does not break
anything. Lev has given 808+809+810 another test run on the "modified
community server" (thanks!), and Corp QA has been asked to test against
OpenVPN Inc commercial server infrastructure (so we'll hear if it does
not work).
(Staring again, I *did* find one thing we should fix, namely the
amount of options passed to apply_push_options() now, but this can
be done in a new patch)
My plan for future testing is to integrate this into the t_client/t_server
testbeds, setting up one instance that will do PUSH_UPDATE to send over
the routes that are needed for ping success - but this needs #869 and
quite a bit of new "drive management interface" infrastructure to get
done. Soon. *cough*.
Your patch has been applied to the master branch.
commit 80b62545881cbe39e813c85c23984e62aaa76860
Author: Marco Baffo
Date: Tue Jul 29 12:40:39 2025 +0200
PUSH_UPDATE: Allow OpenVPN in client mode to receive and handle PUSH
UPDATE control messages to allow options updating at runtime.
Signed-off-by: Marco Baffo <ma...@mandelbit.com>
Acked-by: Gert Doering <g...@greenie.muc.de>
Message-Id: <20250729104045.27582-1-g...@greenie.muc.de>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32406.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
