Attention is currently required from: flichtenheld, plaisthos, stipa.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1090?usp=email )
Change subject: Fix broken DHCP options
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
This plays together with the code in tun.c that checks whether or not the TAP
driver needs to be informed about DHCP options
```
/* user-supplied DHCP options capability */
if (tt->options.dhcp_options)
{
..
if (!DeviceIoControl(tt->hand, TAP_WIN_IOCTL_CONFIG_DHCP_SET_OPT,
..
```
... so if we no longer flag these "it can be done with DHCP or not" options as
"well, if we have DHCP, we should set them!" (DHCP_OPTIONS_DHCP_OPTIONAL), and
we have no "this can only be done with DHCP!" options
(DHCP_OPTIONS_DHCP_REQUIRED), then tun.c just assumes "well, nothing required,
nothing to set up" and DNS will not work.
I experienced the issue myself with 2.7_alpha2 and a setup that ended up using
TAP and DHCP, and the explanation makes sense.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1090?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0d75efcceb826d06e74abd003d5377468ff9fe3b
Gerrit-Change-Number: 1090
Gerrit-PatchSet: 1
Gerrit-Owner: stipa <lstipa...@gmail.com>
Gerrit-Reviewer: cron2 <g...@greenie.muc.de>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Attention: stipa <lstipa...@gmail.com>
Gerrit-Comment-Date: Wed, 30 Jul 2025 18:04:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
