This looks generally reasonable, and if Heiko (who understands the "DNS related data flow" around options.c way better than I do) says this is fine, it should be :-) - so, in it goes, just in time for Alpha3...
Test compiled on Windows/MinGW (as the buildbots are busy and I am impatient). Your patch has been applied to the master branch. commit 70d4c6776bd563f487add399bd4acf58c5e22334 Author: Lev Stipakov Date: Thu Jul 31 14:24:05 2025 +0200 Fix DNS options duplication on PUSH_UPDATE Signed-off-by: Lev Stipakov <l...@openvpn.net> Acked-by: Heiko Hund <he...@openvpn.net> Message-Id: <20250731122410.12200-1-g...@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32448.html Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel