cron2 has uploaded a new patch set (#2) to the change originally created by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/1125?usp=email )
The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: Fix wrong byte order of --dns server ...................................................................... Fix wrong byte order of --dns server We already fixed it in commit 82fd89a04f, but the fix got lost in 2dfc4f8. tuntap_options require host byte order, and we store dns servers in struct dns_server in network byte order, what we got from getaddrinfo(). Fix (again) by converting to the host byte order. Change-Id: I37ca672f05e9d77ec586fa28dadc6dc752e574fb Signed-off-by: Lev Stipakov <l...@openvpn.net> Acked-by: Gert Doering <g...@greenie.muc.de> Message-Id: <20250731152912.21826-1-g...@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32460.html Signed-off-by: Gert Doering <g...@greenie.muc.de> --- M src/openvpn/options.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/25/1125/2 diff --git a/src/openvpn/options.c b/src/openvpn/options.c index 3ceada0..ff9addd 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -3573,7 +3573,7 @@ { if (s->addr[i].family == AF_INET && tt->dns_len + 1 < N_DHCP_ADDR) { - tt->dns[tt->dns_len++] = s->addr[i].in.a4.s_addr; + tt->dns[tt->dns_len++] = ntohl(s->addr[i].in.a4.s_addr); } else if (tt->dns6_len + 1 < N_DHCP_ADDR) { -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1125?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I37ca672f05e9d77ec586fa28dadc6dc752e574fb Gerrit-Change-Number: 1125 Gerrit-PatchSet: 2 Gerrit-Owner: stipa <lstipa...@gmail.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-MessageType: newpatchset
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel