Attention is currently required from: flichtenheld, plaisthos. its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1089?usp=email )
Change subject: multipeer: introduce asymmetric peer-id ...................................................................... Patch Set 2: (5 comments) File src/openvpn/multi.c: http://gerrit.openvpn.net/c/openvpn/+/1089/comment/d20f4c46_6ddf1dff : PS2, Line 1816: uint32_t peer_id = extract_asymmetric_peer_id(peer_info); > I am somehow missing the client side/p2p that does the same and also calls > extract_asymmetric_peer_i […] Acknowledged File src/openvpn/push.c: http://gerrit.openvpn.net/c/openvpn/+/1089/comment/dfe60a3c_ec0e72ed : PS2, Line 657: tls_multi->rx_peer_id); > This will instruct the client to use that peer-id on both send/receive. […] ok but what about the mapping? we're using the current peer-id assigned by the server as index to keep track of the instances, should we implement a different kind of mapping? Of curse on server side I will prepend to the buffer the tx_peer_id (if supported) along with the opcode but yeah the client will keep prepending the old one. File src/openvpn/ssl.c: http://gerrit.openvpn.net/c/openvpn/+/1089/comment/7a3b0954_5bc84265 : PS2, Line 2043: buf_printf(&out, "ID=%x\n", peer_id); > This need to be guarded by the actual DCO capability. […] Acknowledged File src/openvpn/ssl_ncp.c: http://gerrit.openvpn.net/c/openvpn/+/1089/comment/1f01bfff_92f0595e : PS2, Line 431: multi->tx_peer_id = 2033; > Why the hardcoded 2033 here? Shouldn't be also 0x76706e; /* 'v' 'p' 'n' */ ? yeah that was just for testing purposes, will fix this. http://gerrit.openvpn.net/c/openvpn/+/1089/comment/32efaf15_5871df14 : PS2, Line 474: multi->rx_peer_id = (peerid[0] << 16) + (peerid[1] << 8) + peerid[2]; > Shouldn't there be code here So you're saying we should keep the peer_id field and also the rx_peer_id and tx_peer_id but use them only if supported? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1089?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I0a13ee90b6706acf20eabcee3bab3f2dff639bf9 Gerrit-Change-Number: 1089 Gerrit-PatchSet: 2 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Tue, 05 Aug 2025 07:56:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: plaisthos <arne-open...@rfc2549.org> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
