Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1138?usp=email
to review the following change.
Change subject: ssl_verify: Change backend_x509_* functions to size_t for
lengths
......................................................................
ssl_verify: Change backend_x509_* functions to size_t for lengths
Fix conversion warnings without actual code changes.
Change-Id: If971006b6d3a1a93d87b29627d91dd72faf5ceb2
Signed-off-by: Frank Lichtenheld <fr...@lichtenheld.com>
---
M src/openvpn/ssl_verify_backend.h
M src/openvpn/ssl_verify_mbedtls.c
M src/openvpn/ssl_verify_openssl.c
3 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/38/1138/1
diff --git a/src/openvpn/ssl_verify_backend.h b/src/openvpn/ssl_verify_backend.h
index af7a08f..8a1e0e1 100644
--- a/src/openvpn/ssl_verify_backend.h
+++ b/src/openvpn/ssl_verify_backend.h
@@ -123,7 +123,7 @@
*
* @return \c FAILURE, \c or SUCCESS
*/
-result_t backend_x509_get_username(char *common_name, int cn_len, char
*x509_username_field,
+result_t backend_x509_get_username(char *common_name, size_t cn_len, char
*x509_username_field,
openvpn_x509_cert_t *peer_cert);
#ifdef ENABLE_X509ALTUSERNAME
diff --git a/src/openvpn/ssl_verify_mbedtls.c b/src/openvpn/ssl_verify_mbedtls.c
index eb556c1..ae045de 100644
--- a/src/openvpn/ssl_verify_mbedtls.c
+++ b/src/openvpn/ssl_verify_mbedtls.c
@@ -128,7 +128,7 @@
#endif
result_t
-backend_x509_get_username(char *cn, int cn_len, char *x509_username_field,
mbedtls_x509_crt *cert)
+backend_x509_get_username(char *cn, size_t cn_len, char *x509_username_field,
mbedtls_x509_crt *cert)
{
mbedtls_x509_name *name;
diff --git a/src/openvpn/ssl_verify_openssl.c b/src/openvpn/ssl_verify_openssl.c
index 22659aa..c72785a 100644
--- a/src/openvpn/ssl_verify_openssl.c
+++ b/src/openvpn/ssl_verify_openssl.c
@@ -120,7 +120,7 @@
}
static bool
-extract_x509_extension(X509 *cert, char *fieldname, char *out, int size)
+extract_x509_extension(X509 *cert, char *fieldname, char *out, size_t size)
{
bool retval = false;
char *buf = 0;
@@ -195,7 +195,7 @@
* to contain result is grounds for error).
*/
static result_t
-extract_x509_field_ssl(X509_NAME *x509, const char *field_name, char *out, int
size)
+extract_x509_field_ssl(X509_NAME *x509, const char *field_name, char *out,
size_t size)
{
int lastpos = -1;
int tmp = -1;
@@ -252,7 +252,7 @@
}
result_t
-backend_x509_get_username(char *common_name, int cn_len, char
*x509_username_field, X509 *peer_cert)
+backend_x509_get_username(char *common_name, size_t cn_len, char
*x509_username_field, X509 *peer_cert)
{
#ifdef ENABLE_X509ALTUSERNAME
if (strncmp("ext:", x509_username_field, 4) == 0)
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1138?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: If971006b6d3a1a93d87b29627d91dd72faf5ceb2
Gerrit-Change-Number: 1138
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-MessageType: newchange
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
