Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1146?usp=email
to review the following change.
Change subject: t_server_null: remove the --dh parameter altogether
......................................................................
t_server_null: remove the --dh parameter altogether
Change-Id: I27a7519ab3ae629d3dc634ad3e9e2120e524e669
Signed-off-by: Samuli Seppänen <sas...@pm.me>
---
M tests/t_server_null_default.rc
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/46/1146/1
diff --git a/tests/t_server_null_default.rc b/tests/t_server_null_default.rc
index 900f189..51c21c9 100755
--- a/tests/t_server_null_default.rc
+++ b/tests/t_server_null_default.rc
@@ -13,7 +13,6 @@
top_builddir="${top_builddir:-..}"
sample_keys="${srcdir}/../sample/sample-keys"
-DH="${sample_keys}/dh2048.pem"
CA="${sample_keys}/ca.crt"
CLIENT_CERT="${sample_keys}/client.crt"
CLIENT_KEY="${sample_keys}/client.key"
@@ -57,13 +56,13 @@
SERVER_SERVER_2="--server 10.29.42.0 255.255.255.0"
SERVER_MGMT_PORT_2="11195"
SERVER_EXEC_2="${SERVER_EXEC}"
-SERVER_CONF_2="${SERVER_CONF_BASE} ${SERVER_SERVER_2} --lport 1195 --proto tcp
--management 127.0.0.1 ${SERVER_MGMT_PORT_2} --dh ${DH}"
+SERVER_CONF_2="${SERVER_CONF_BASE} ${SERVER_SERVER_2} --lport 1195 --proto tcp
--management 127.0.0.1 ${SERVER_MGMT_PORT_2}"
SERVER_NAME_3="t_server_null_server-1196_udp"
SERVER_SERVER_3="--server 10.29.43.0 255.255.255.0"
SERVER_MGMT_PORT_3="11196"
SERVER_EXEC_3="${SERVER_EXEC}"
-SERVER_CONF_3="${SERVER_CONF_BASE} ${SERVER_SERVER_3} --lport 1196 --proto udp
--management 127.0.0.1 ${SERVER_MGMT_PORT_3} --dh none --cipher AES-192-CBC
--data-ciphers DEFAULT:AES-192-CBC"
+SERVER_CONF_3="${SERVER_CONF_BASE} ${SERVER_SERVER_3} --lport 1196 --proto udp
--management 127.0.0.1 ${SERVER_MGMT_PORT_3} --cipher AES-192-CBC
--data-ciphers DEFAULT:AES-192-CBC"
SERVER_NAME_4="t_server_null_server-1197_multisocket_ipv4_ipv6"
SERVER_SERVER_4="--server 10.29.44.0 255.255.255.0"
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1146?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I27a7519ab3ae629d3dc634ad3e9e2120e524e669
Gerrit-Change-Number: 1146
Gerrit-PatchSet: 1
Gerrit-Owner: mattock <sas...@proton.me>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-MessageType: newchange
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
