Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1196?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+2 by flichtenheld
Change subject: dev-tools/gerrit-send-mail.py: include Gerrit URL into the
commit message
......................................................................
dev-tools/gerrit-send-mail.py: include Gerrit URL into the commit message
We used to reference to one of the mailing list archives as the formal
reference for the patch and the review discussions. With the problematic
reliability of the archives, I've started to manually add the URLs in
the OpenVPN Gerrit to the commits because they give a better reference
and (usually) all the feedback is there in a useful format.
So, enhance this dev-tool script to do this automatically.
Change-Id: Idb137ecbade4b0584a4d74aee34978062e247bc5
Signed-off-by: Gert Doering <[email protected]>
Acked-by: Frank Lichtenheld <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1196
Message-Id: <[email protected]>
URL: https://sourceforge.net/p/openvpn/mailman/message/59234672/
Signed-off-by: Gert Doering <[email protected]>
---
M dev-tools/gerrit-send-mail.py
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/96/1196/3
diff --git a/dev-tools/gerrit-send-mail.py b/dev-tools/gerrit-send-mail.py
index 0b49ae9..450e920 100755
--- a/dev-tools/gerrit-send-mail.py
+++ b/dev-tools/gerrit-send-mail.py
@@ -99,6 +99,7 @@
assert comment_start > signed_off_end
acked_by_text = ""
acked_by_names = ""
+ gerrit_url = f"{args.url}/c/{details['project']}/+/{args.changeid}"
for ack in details["acked_by"]:
acked_by_text += f"Acked-by: {ack}\n"
acked_by_names += f"{ack}\n"
@@ -106,12 +107,13 @@
patch_text[:signed_off_end]
+ signed_off_text
+ acked_by_text
+ + f"Gerrit URL: {gerrit_url}\n"
+ patch_text[signed_off_end:comment_start]
+ f"""
This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to {details["target"]}.
-Gerrit URL: {args.url}/c/{details["project"]}/+/{args.changeid}
+Gerrit URL: {gerrit_url}
This mail reflects revision {details["revision"]} of this Change.
{signed_off_comment}
Acked-by according to Gerrit (reflected above):
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1196?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Idb137ecbade4b0584a4d74aee34978062e247bc5
Gerrit-Change-Number: 1196
Gerrit-PatchSet: 3
Gerrit-Owner: cron2 <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: newpatchset
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
