Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1260?usp=email
to review the following change.
Change subject: lzo: Fix conversion warning
......................................................................
lzo: Fix conversion warning
We already have an assert ensuring the value is sane,
so just add the cast.
Change-Id: I4a5c46f321709c83a4a921366630fb8e02834701
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M src/openvpn/lzo.c
1 file changed, 1 insertion(+), 10 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/60/1260/1
diff --git a/src/openvpn/lzo.c b/src/openvpn/lzo.c
index 8daaec0..8307b59 100644
--- a/src/openvpn/lzo.c
+++ b/src/openvpn/lzo.c
@@ -72,11 +72,6 @@
*header = NO_COMPRESS_BYTE;
}
-#if defined(__GNUC__) || defined(__clang__)
-#pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Wconversion"
-#endif
-
static void
lzo_decompress(struct buffer *buf, struct buffer work, struct compress_context
*compctx,
const struct frame *frame)
@@ -107,7 +102,7 @@
}
ASSERT(buf_safe(&work, zlen));
- work.len = zlen;
+ work.len = (int)zlen;
dmsg(D_COMP, "LZO decompress %d -> %d", buf->len, work.len);
compctx->pre_decompress += buf->len;
@@ -126,10 +121,6 @@
}
}
-#if defined(__GNUC__) || defined(__clang__)
-#pragma GCC diagnostic pop
-#endif
-
const struct compress_alg lzo_alg = { "lzo", lzo_compress_init,
lzo_compress_uninit, lzo_compress,
lzo_decompress };
#endif /* ENABLE_LZO */
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1260?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4a5c46f321709c83a4a921366630fb8e02834701
Gerrit-Change-Number: 1260
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
