Attention is currently required from: cron2, flichtenheld, mrbff. plaisthos has posted comments on this change by mrbff. ( http://gerrit.openvpn.net/c/openvpn/+/677?usp=email )
Change subject: route: copied 'gateway_needed' logic from add_route_ipv6 to add_route ...................................................................... Patch Set 11: (2 comments) Patchset: PS11: This changes the logic of adding routes on all platforms in a very drastic way. This requires at least a note in Changes.rst to call this different default behaviour out. File src/openvpn/route.c: http://gerrit.openvpn.net/c/openvpn/+/677/comment/3706b988_994b1a63?usp=email : PS11, Line 1606: gateway_needed = true; Sure but why is the gateway needed in this case? And why is this always the vpn server special route? For me this is not obvious and I would like some comment describing the reason here. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/677?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Id1ec0c6e4c391604ec5dbb8b7122f2e47ad186d1 Gerrit-Change-Number: 677 Gerrit-PatchSet: 11 Gerrit-Owner: mrbff <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: cron2 <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: cron2 <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Attention: mrbff <[email protected]> Gerrit-Comment-Date: Mon, 13 Oct 2025 14:49:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
