Attention is currently required from: flichtenheld. plaisthos has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1207?usp=email )
Change subject: Enable -Wtype-limits by default (via -Wextra) ...................................................................... Patch Set 3: Code-Review-1 (1 comment) File src/openvpn/init.c: http://gerrit.openvpn.net/c/openvpn/+/1207/comment/c01e41e9_729132bc?usp=email : PS3, Line 2732: bool datav2_enabled = c->options.peer_id < MAX_PEER_ID; Yes that is correct from the standpoint of no sign compare but the check should be fixed to actually do what it says. Replace the first part with c->options.use_peer_id -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1207?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iaabddb6f81cd94863291b193aae9d384a8f9d871 Gerrit-Change-Number: 1207 Gerrit-PatchSet: 3 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Tue, 14 Oct 2025 09:47:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
