Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1244?usp=email )
Change subject: test_options_parse: Start new UT for options_parse.c ...................................................................... Patch Set 3: Code-Review-1 (2 comments) Patchset: PS3: confused about _wrap_* File tests/unit_tests/openvpn/test_options_parse.c: http://gerrit.openvpn.net/c/openvpn/+/1244/comment/96e18f0a_7dec87ea?usp=email : PS3, Line 41: __wrap_add_option(struct options *options, char *p[], bool is_inline, const char *file, why _wrap_...? Shouldn't this just work with normal linking, given that we do not link options.o? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1244?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I95032d2539d994abf69fc17319ed1a429c3bb948 Gerrit-Change-Number: 1244 Gerrit-PatchSet: 3 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Tue, 07 Oct 2025 20:05:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
