Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change by flichtenheld. (
http://gerrit.openvpn.net/c/openvpn/+/1267?usp=email )
Change subject: test_dhcp: Start a dhcp helper functions UT
......................................................................
Patch Set 1: Code-Review-2
(1 comment)
Patchset:
PS1:
```
test_dhcp.c: In function ‘test_write_dhcp_search_str’:
test_dhcp.c:71:83: error: \x used with no following hex digits
71 | const char output_1[27] =
"\x77\x1a\x07openvpn\x03net\x00\x07openvpn\x{03}com";
|
^
test_dhcp.c:71:31: error: initializer-string for array of ‘char’ is too long
[-Werror]
71 | const char output_1[27] =
"\x77\x1a\x07openvpn\x03net\x00\x07openvpn\x{03}com";
|
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test_dhcp.c:116:64: error: \x used with no following hex digits
116 | const char output_5[15] = "\x77\x0d\x03sub\x00\x{06}domain";
| ^
test_dhcp.c:116:31: error: initializer-string for array of ‘char’ is too long
[-Werror]
116 | const char output_5[15] = "\x77\x0d\x03sub\x00\x{06}domain";
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[2]: *** [Makefile:3164: dhcp_testdriver-test_dhcp.o] Error 1
```
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1267?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I08e50030b1b692d351509f541e5c0b03b5170615
Gerrit-Change-Number: 1267
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Sat, 11 Oct 2025 09:06:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
