Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/474?usp=email )
The change is no longer submittable: Code-Review is unsatisfied now. Change subject: test_user_pass: Check fatal errors for empty username/password ...................................................................... Patch Set 13: Code-Review-2 (1 comment) Patchset: PS13: While it passes BB and GHA checks(!), it fails for my local builds - both on Linux and FreeBSD. Output is just ``` ... PASS: ssl_testdriver FAIL: user_pass_testdriver PASS: push_update_msg_testdriver ... ``` if I run the binary from hand (not sure if this is supposed to work, it works for all the other tests) it says ``` gert@gentoo ~/t_server.git/tests/unit_tests/openvpn $ ./user_pass_testdriver [==========] Running 10 test(s). [ RUN ] test_get_user_pass_defined ... [ RUN ] test_get_user_pass_authfile_file_assertions [ ERROR ] --- srcdir [ LINE ] --- test_common.h:63: error: Failure! [ FAILED ] test_get_user_pass_authfile_file_assertions [==========] 10 test(s) run. [ PASSED ] 8 test(s). [ FAILED ] 2 test(s), listed below: [ FAILED ] test_get_user_pass_authfile_file [ FAILED ] test_get_user_pass_authfile_file_assertions 2 FAILED TEST(S) [ RUN ] test_get_user_pass_authfile_file_assertions [ ERROR ] --- srcdir [ LINE ] --- test_common.h:63: error: Failure! [ FAILED ] test_get_user_pass_authfile_file_assertions [==========] 10 test(s) run. [ PASSED ] 8 test(s). [ FAILED ] 2 test(s), listed below: [ FAILED ] test_get_user_pass_authfile_file [ FAILED ] test_get_user_pass_authfile_file_assertions 2 FAILED TEST(S) ``` I first thought it's something with "in tree builds", but it also fails "out of tree" builds (only tested on FreeBSD). Maybe cmocka version? 1.1.8 on FreeBSD, 1.1.5-r1 on gentoo. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/474?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Icabc8acf75638c86c8c395e9ffecba7a7226cd97 Gerrit-Change-Number: 474 Gerrit-PatchSet: 13 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Fri, 10 Oct 2025 21:28:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
