Attention is currently required from: flichtenheld, plaisthos, ralf_lici. stipa has posted comments on this change by ralf_lici. ( http://gerrit.openvpn.net/c/openvpn/+/1285?usp=email )
Change subject: management: ensure consistent BYTECOUNT timing on server ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: LGTM. The previous implementation triggered BYTECOUNT callback at most every 10 seconds, even with a smaller interval - this is due to instance reaper timeout being set to 10 secs, and we haven't checked BYTECOUNT timeout against any timeval instance. This checks BYTECOUNT timeout expiration against multi->top.c2.timeval, the one used by multi_io_wait, which means that any interval will now work. Tested on Windows server setup. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1285?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ifb1c49fce75e671f699f5db5f6da7246f6e0b519 Gerrit-Change-Number: 1285 Gerrit-PatchSet: 2 Gerrit-Owner: ralf_lici <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-Reviewer: stipa <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Attention: ralf_lici <[email protected]> Gerrit-Comment-Date: Tue, 21 Oct 2025 07:00:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
