Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1298?usp=email
to review the following change.
Change subject: ssl: Fix conversion warning in tls_prepend_opcode_v1
......................................................................
ssl: Fix conversion warning in tls_prepend_opcode_v1
Document assumption with ASSERT.
Change-Id: I34584f695ddca3b3e1f2bbcb4380ac91b09c1c8d
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M src/openvpn/ssl.c
1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/98/1298/1
diff --git a/src/openvpn/ssl.c b/src/openvpn/ssl.c
index dfbbbc6..54b69ea 100644
--- a/src/openvpn/ssl.c
+++ b/src/openvpn/ssl.c
@@ -3974,24 +3974,24 @@
}
}
+#if defined(__GNUC__) || defined(__clang__)
+#pragma GCC diagnostic pop
+#endif
+
void
tls_prepend_opcode_v1(const struct tls_multi *multi, struct buffer *buf)
{
struct key_state *ks = multi->save_ks;
- uint8_t op;
msg(D_TLS_DEBUG, __func__);
ASSERT(ks);
+ ASSERT(ks->key_id <= 1 << P_OPCODE_SHIFT);
- op = (P_DATA_V1 << P_OPCODE_SHIFT) | ks->key_id;
+ uint8_t op = (P_DATA_V1 << P_OPCODE_SHIFT) | (uint8_t)ks->key_id;
ASSERT(buf_write_prepend(buf, &op, 1));
}
-#if defined(__GNUC__) || defined(__clang__)
-#pragma GCC diagnostic pop
-#endif
-
void
tls_prepend_opcode_v2(const struct tls_multi *multi, struct buffer *buf)
{
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1298?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I34584f695ddca3b3e1f2bbcb4380ac91b09c1c8d
Gerrit-Change-Number: 1298
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
