Attention is currently required from: MaxF, plaisthos. flichtenheld has posted comments on this change by MaxF. ( http://gerrit.openvpn.net/c/openvpn/+/1304?usp=email )
Change subject: Add option to check tls-crypt-v2 key timestamps ...................................................................... Patch Set 2: Code-Review-2 (1 comment) File src/openvpn/tls_crypt.c: http://gerrit.openvpn.net/c/openvpn/+/1304/comment/a2d3dd24_9363c859?usp=email : PS2, Line 679: return tls_crypt_v2_check_client_key_age(ctx, opt->tls_crypt_v2_max_age); that is logically wrong. You skip the verify_metadata check below unconditionally, but can only that on failure. You can just copy the if from below since only the last check can do it this way. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1304?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I0579d18c784e2ac16973d5553992c28f281a0900 Gerrit-Change-Number: 1304 Gerrit-PatchSet: 2 Gerrit-Owner: MaxF <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: MaxF <[email protected]> Gerrit-Comment-Date: Sun, 26 Oct 2025 21:16:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
