Took a bit between +2 and merge, but here we are :-)
Tested on FreeBSD+DCO with "bytecount 2", which used to do "10 seconds
and no less". New code does 2s if 2s is ordered... whether or not that
is *useful* depends on the management client, I'd say :-) - but having
consistent behaviour is a good thing.
Looking at the code, I did wonder why multi_get_timeout_instance()
lives in multi.h, when it is only used from multi.c - this is actually
a multisocket artefact. 2.6 calls this from mudp.c and mtcp.c, so
it made sense. master/2.7 only calls this from multi.c, so we could
move it in there eventually.
Your patch has been applied to the master branch.
commit a5ee6a1d642ae365eae78fd04d51976c365b2b59
Author: Ralf Lici
Date: Tue Oct 21 09:08:20 2025 +0200
management: ensure consistent BYTECOUNT timing on server
Signed-off-by: Ralf Lici <[email protected]>
Acked-by: Lev Stipakov <[email protected]>
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg33812.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
