Attention is currently required from: cron2, flichtenheld, plaisthos, selvanair.

d12fk has posted comments on this change by d12fk. ( 
http://gerrit.openvpn.net/c/openvpn/+/1307?usp=email )

Change subject: iservice: validate config path better
......................................................................


Patch Set 3:

(2 comments)

File src/openvpnserv/validate.c:

http://gerrit.openvpn.net/c/openvpn/+/1307/comment/14df14a0_d3e23416?usp=email :
PS3, Line 88:     HRESULT res = PathCchCanonicalizeEx(config_dir, 
_countof(config_dir), s->config_dir,
> As you are effectively reverting commit 05a8ba808, also remove 
> "HAVE_PATHCCH_ENSURE_TRAILING_SLASH"  […]
Done in #1354


http://gerrit.openvpn.net/c/openvpn/+/1307/comment/2e5dfd92_b85abcb8?usp=email :
PS3, Line 85:     return res == S_OK && wcsncmp(config_path, s->config_dir, 
wcslen(s->config_dir)) == 0;
> While at it, make this case insensitve.
Done



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1307?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0e94068f467f2899daf133b032a785d2d7fc05e4
Gerrit-Change-Number: 1307
Gerrit-PatchSet: 3
Gerrit-Owner: d12fk <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: selvanair <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: cron2 <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Attention: selvanair <[email protected]>
Gerrit-Comment-Date: Thu, 06 Nov 2025 21:00:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: selvanair <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to