Attention is currently required from: flichtenheld, plaisthos, stipa. d12fk has posted comments on this change by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/1333?usp=email )
Change subject: openvpnserv: validate openvpn-gui process path ...................................................................... Patch Set 2: (3 comments) File src/openvpnserv/validate.c: http://gerrit.openvpn.net/c/openvpn/+/1333/comment/8a56b40a_84d5cd59?usp=email : PS2, Line 350: if (!GetNamedPipeClientProcessId(pipe, &clientPID)) I remember we looked at this back when the reports from Microsoft came in. Not sure if I recall correctly, but wasn't it this API which always reported the same PID no matter which process connected to the pipe second? http://gerrit.openvpn.net/c/openvpn/+/1333/comment/6c18fe77_e5aadcaa?usp=email : PS2, Line 371: HRESULT hr = PathCchCanonicalizeEx(bin_dir, _countof(bin_dir), s->bin_dir, dirs will always have a trailing slash with #1336 http://gerrit.openvpn.net/c/openvpn/+/1333/comment/a4c3a93c_555a1a40?usp=email : PS2, Line 373: if ((hr == S_OK) && wcsncmp(bin_dir, path, wcslen(bin_dir)) == 0) Compare case-insesitive here, to get no false positives -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1333?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie990f4dd10094810d6632f8dedfa261727ebfbcb Gerrit-Change-Number: 1333 Gerrit-PatchSet: 2 Gerrit-Owner: stipa <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: d12fk <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-CC: selvanair <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Attention: stipa <[email protected]> Gerrit-Comment-Date: Sat, 08 Nov 2025 00:07:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
