Attention is currently required from: flichtenheld.

plaisthos has posted comments on this change by flichtenheld. ( 
http://gerrit.openvpn.net/c/openvpn/+/1360?usp=email )

Change subject: ssl_pkt: Avoid conversion warnings
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

File src/openvpn/ssl_pkt.c:

http://gerrit.openvpn.net/c/openvpn/+/1360/comment/a1fe2aaa_8b703041?usp=email :
PS1, Line 168:     ASSERT(ks->key_id >= 0 && ks->key_id <= 1 << P_OPCODE_SHIFT);
key should be <= 7 instead of <= 8. I think this is the same problem as in 
https://gerrit.openvpn.net/c/openvpn/+/1298/3/src/openvpn/ssl.c#3985



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1360?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2a1786b2bf15852222c28e1b73ab7edbb5f19d7f
Gerrit-Change-Number: 1360
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Tue, 11 Nov 2025 11:13:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to