Attention is currently required from: plaisthos, stipa. cron2 has posted comments on this change by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/1374?usp=email )
Change subject: tapctl: refactor 'create' command ...................................................................... Patch Set 2: Code-Review+2 (3 comments) Patchset: PS2: some room for improvement left, but moving on File src/tapctl/main.c: http://gerrit.openvpn.net/c/openvpn/+/1374/comment/341b165d_9f6f6845?usp=email : PS2, Line 221: } this code is a bit silly - two `free(value)` and `break`, where the second one would nicely cover what is in the `if()` above. But it's not going to break anything, we can fix this later. http://gerrit.openvpn.net/c/openvpn/+/1374/comment/327981bf_81d31cdf?usp=email : PS2, Line 362: } I did not manage to trigger this one - `tapctl create --hwid dings` will fail earlier on (`DiInstallDevice failed`), so I guess I need a valid hwid yet unknown to tapctl to trigger this. But the code is ok. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1374?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I270f679505c90ef78a5afbad1e05219f166be089 Gerrit-Change-Number: 1374 Gerrit-PatchSet: 2 Gerrit-Owner: stipa <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: stipa <[email protected]> Gerrit-Comment-Date: Sun, 16 Nov 2025 12:11:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
