Stared at the code, commented on a few things I could not test or that
look a bit unelegant. (Side note: changing back and forth between
pAdapterList and adapter_list in the patch series didn't help review).
Decided to go on nevertheless, as this was all minor and the overall
change is useful & looks correct.
Tested the mingw-compiled binary on Win11 24H2 ARM, and all the variants
(create, delete, named, names with ** in them, auto-names) worked for me.
Your patch has been applied to the master branch.
commit 8487dbf1606c4c5f787dcf015228f1a05378da17
Author: Lev Stipakov
Date: Sun Nov 16 13:11:40 2025 +0100
tapctl: refactor 'create' command
Signed-off-by: Lev Stipakov <[email protected]>
Acked-by: Gert Doering <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1374
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg34455.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
